build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37871 )
Change subject: soc/intel/common/block: Enable PMC IPC driver
......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37871/8/src/soc/intel/common/block/...
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/37871/8/src/soc/intel/common/block/...
PS8, Line 25: #inclued <security/vboot/vboot_common.h>
'inclued' may be misspelled - perhaps 'included'?
https://review.coreboot.org/c/coreboot/+/37871/8/src/soc/intel/common/block/...
PS8, Line 25: #inclued <security/vboot/vboot_common.h>
spaces required around that '<' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/37871/8/src/soc/intel/common/block/...
PS8, Line 25: #inclued <security/vboot/vboot_common.h>
spaces required around that '>' (ctx:VxE)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37871
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd3ed262fc700ccc891ec68997a108f5bfbaf9ed
Gerrit-Change-Number: 37871
Gerrit-PatchSet: 8
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-CC: Vijay P Hiremath
vijay.p.hiremath@intel.com
Gerrit-Comment-Date: Thu, 30 Jan 2020 22:45:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment