Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48479 )
Change subject: mb/google/guybrush: Add new mainboard ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/48479/7/src/mainboard/google/guybru... File src/mainboard/google/guybrush/Kconfig:
https://review.coreboot.org/c/coreboot/+/48479/7/src/mainboard/google/guybru... PS7, Line 3: config BOARD_GOOGLE_BASEBOARD_GUYBRUSH : def_bool n : select SOC_AMD_CEZANNE
You'll probably get rid of the build errors by adding "if BOARD_GOOGLE_BASEBOARD_GUYBRUSH" after thi […]
Done. Thanks!
https://review.coreboot.org/c/coreboot/+/48479/7/src/mainboard/google/guybru... File src/mainboard/google/guybrush/board_info.txt:
https://review.coreboot.org/c/coreboot/+/48479/7/src/mainboard/google/guybru... PS7, Line 6: n
Is there any special support required for this SoC?
martinroth@ This is how Zork is set up, do you know why? I am not familiar with what this flag does.
https://review.coreboot.org/c/coreboot/+/48479/7/src/mainboard/google/guybru... File src/mainboard/google/guybrush/bootblock.c:
https://review.coreboot.org/c/coreboot/+/48479/7/src/mainboard/google/guybru... PS7, Line 5: #include <acpi/acpi.h>
Can be added later when required.
Done