Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31328 )
Change subject: mb/google/hatch: Configure GPIO pad for non-inversion
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/31328/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31328/4//COMMIT_MSG@9
PS4, Line 9: GPIO(GPP_A21, GPP_C21, GPP_D16)
Please add a space before the (.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31328
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6034fd07ccc96a19218d57ef8bb9049c4b963ea5
Gerrit-Change-Number: 31328
Gerrit-PatchSet: 4
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rajat Jain
rajatja@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 12 Feb 2019 12:13:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment