Attention is currently required from: Nico Huber, Julius Werner.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56210 )
Change subject: console: Handle verstage as "first non-bootblock stage"
......................................................................
Patch Set 1:
(1 comment)
File src/console/init.c:
https://review.coreboot.org/c/coreboot/+/56210/comment/cd01ee07_743824c7
PS1, Line 15: #endif
Sorry, I don't understand: What difference would it make to use ENV_INITIAL_STAGE […]
For one, some stages are _pretty_ packed, e.g. verstage on google/veyron. Especially with the follow-on that takes a couple more bytes to add CBFS support, verstage is overflowing there, so cutting down on that is worthwhile.
(Not to say that it should be done _this_ way, but there needs to be _some_ way)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56210
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I494a33483e306a049aa0c8137a118644fc28177e
Gerrit-Change-Number: 56210
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 14 Jul 2021 18:57:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment