build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38593 )
Change subject: sc7180: GPIO: Add I2S configuration for sc7180 ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38593/3/src/soc/qualcomm/sc7180/qi2... File src/soc/qualcomm/sc7180/qi2s.c:
https://review.coreboot.org/c/coreboot/+/38593/3/src/soc/qualcomm/sc7180/qi2... PS3, Line 37: GPIO_8MA, GPIO_OUTPUT); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38593/3/src/soc/qualcomm/sc7180/qi2... PS3, Line 41: GPIO_8MA, GPIO_OUTPUT); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38593/3/src/soc/qualcomm/sc7180/qi2... PS3, Line 43: GPIO_8MA, GPIO_OUTPUT); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38593/3/src/soc/qualcomm/sc7180/qi2... PS3, Line 48: void qi2s_init() Bad function definition - void qi2s_init() should probably be void qi2s_init(void)