Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30990 )
Change subject: soc/apollolake: Generate DMAR table
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/30990/5/src/soc/intel/apollolake/acpi.c
File src/soc/intel/apollolake/acpi.c:
https://review.coreboot.org/#/c/30990/5/src/soc/intel/apollolake/acpi.c@247
PS5, Line 247: !(MCHBAR32(DEFVTBAR) & VTBAR_ENABLED))
Yes, second line. And I meant indentation relative to the `if`. […]
OK, got it. Thank you for explaining, will change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30990
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3683a2f3578c141c691b2268e32f27ba2e772fa
Gerrit-Change-Number: 30990
Gerrit-PatchSet: 6
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 25 Jan 2019 11:16:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment