Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36273 )
Change subject: lib/cbmem_top: Add a common cbmem_top implementation
......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36273/10/src/include/cbmem.h
File src/include/cbmem.h:
https://review.coreboot.org/c/coreboot/+/36273/10/src/include/cbmem.h@78
PS10, Line 78: * and later stages. */
Which I still hold is an incorrect assumption. But the code thus far handles it thanks to little endian on x86.
Updated it to say that the result of cbem_top_romstage has to fit in the size of uintptr_t in ramstage.
https://review.coreboot.org/c/coreboot/+/36273/10/src/lib/Kconfig
File src/lib/Kconfig:
https://review.coreboot.org/c/coreboot/+/36273/10/src/lib/Kconfig@31
PS10, Line 31: the
as the?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36273
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie767542ee25483acc9a56785ce20a885e9a63098
Gerrit-Change-Number: 36273
Gerrit-PatchSet: 12
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 29 Oct 2019 21:19:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment