Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38593 )
Change subject: sc7180: GPIO: Add I2S configuration for sc7180 ......................................................................
Patch Set 22:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38593/1/src/soc/qualcomm/sc7180/qi2... File src/soc/qualcomm/sc7180/qi2s.c:
https://review.coreboot.org/c/coreboot/+/38593/1/src/soc/qualcomm/sc7180/qi2... PS1, Line 28: static void configure_gpios(void)
No longer relevant.
Ack
https://review.coreboot.org/c/coreboot/+/38593/1/src/soc/qualcomm/sc7180/qi2... PS1, Line 31: gpio_output(GPIO(49), 1);
No longer relevant.
Ack
https://review.coreboot.org/c/coreboot/+/38593/6/src/soc/qualcomm/sc7180/qi2... File src/soc/qualcomm/sc7180/qi2s.c:
https://review.coreboot.org/c/coreboot/+/38593/6/src/soc/qualcomm/sc7180/qi2... PS6, Line 16: #include <arch/cache.h> : #include <device/mmio.h> : #include <soc/addressmap.h> : #include <soc/gpio.h> : #include <soc/clock.h> : #include <symbols.h> : #include <assert.h> : #include <gpio.h> : #include <string.h> : #include <soc/qi2s.h>
No longer relevant.
Ack