Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38259 )
Change subject: mb/intel/jasperlake_rvp: Remove sd card detect gpio ......................................................................
Patch Set 5:
(5 comments)
https://review.coreboot.org/c/coreboot/+/38259/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38259/4//COMMIT_MSG@7 PS4, Line 7: Commen
I'm asking that we remove the commented-out code before merge, so how about we change this to someth […]
Done
https://review.coreboot.org/c/coreboot/+/38259/4//COMMIT_MSG@11 PS4, Line 11: TODO: We still need to update gpio definition for Jasper Lake soc. : We will update correct gpio for sd card detect once we have Jasper Lake : soc gpio patch. :
Please remove TODO and create a bug to track this work and add the bug number to the comments in thi […]
Ack
https://review.coreboot.org/c/coreboot/+/38259/4//COMMIT_MSG@15 PS4, Line 15: Change-Id: I097b2f3a4fef1a487495a4aa9d2bcf88aa64f017
Please add a section something like this: […]
Done
https://review.coreboot.org/c/coreboot/+/38259/4/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38259/4/src/mainboard/intel/jasperl... PS4, Line 162: # TODO: Replace with correct GPIO definition once gpio_soc_defs.h is
Please remove TODO and create a bug for tracking that work and add the bug number to the CL comments […]
Done
https://review.coreboot.org/c/coreboot/+/38259/4/src/mainboard/intel/jasperl... PS4, Line 164: # register "sdcard_cd_gpio" = "GPP_G5"
Please remove commented-out code.
Done