Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33504 )
Change subject: MSR: Move MSR_PLATFORM_INFO to common place
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://review.coreboot.org/#/c/33504/2/src/include/cpu/x86/msr.h
File src/include/cpu/x86/msr.h:
https://review.coreboot.org/#/c/33504/2/src/include/cpu/x86/msr.h@31
PS2, Line 31: #define PLATFORM_INFO_SET_TDP (1 << 29)
The MSR in question is not architectural. It's not defined with this name even for all intel, thus it does not belong in a directory cpu/x86.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33504
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45cd255e0af4369926a6cb884be9ee71bf1a66de
Gerrit-Change-Number: 33504
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 01 Jul 2019 14:21:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment