Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46217 )
Change subject: tests: Add lib/imd_cbmem-test test case
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/46217/1/tests/lib/imd_cbmem-test.c
File tests/lib/imd_cbmem-test.c:
https://review.coreboot.org/c/coreboot/+/46217/1/tests/lib/imd_cbmem-test.c@...
PS1, Line 7: #include "../lib/imd_cbmem.c"
Tests need to have a way to cleanup imd_cbmem module internal structures. […]
After internal discussions, I agree.
I don't like it, but I understand that it's probably the best choice in this case because of how coreboot is structured and the need to clean things up between unit tests.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46217
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d84c0b589a9360af93d6215ad35abe6d8ee1559
Gerrit-Change-Number: 46217
Gerrit-PatchSet: 1
Gerrit-Owner: Name of user not set #1003143
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 09 Oct 2020 17:17:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Name of user not set #1003143
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-MessageType: comment