Attention is currently required from: Raul Rangel, Nico Huber, Julius Werner, Arthur Heymans, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57860 )
Change subject: arch/x86,cpu/x86: Disable the %gs and %fs segments
......................................................................
Patch Set 4:
(1 comment)
File src/cpu/x86/entry32.S:
https://review.coreboot.org/c/coreboot/+/57860/comment/90588a00_89632d42
PS4, Line 40: %eax, %eax
xor %ax, %ax?
It does not feel like making any difference. But still felt clearing more than required. Same in some other files in this change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57860
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa376e562acc6bd1dfffb7a23bdec82aa474c1d5
Gerrit-Change-Number: 57860
Gerrit-PatchSet: 4
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 24 Sep 2021 15:44:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment