Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61607 )
Change subject: soc/amd/cezanne/psp_verstage: Implement get_uart_base
......................................................................
Patch Set 3:
(2 comments)
File src/soc/amd/cezanne/psp_verstage/uart.c:
https://review.coreboot.org/c/coreboot/+/61607/comment/9815de89_f5571901
PS3, Line 7: FCH_UART_ID_MAX - 1
(Is the -1 here intentional? That means this will only leave room for FCH_UART_ID_0, even though an […]
Nah, it was incorrect. I fixed it in CB:61869, but apparently missed the check below.
https://review.coreboot.org/c/coreboot/+/61607/comment/2c82ff09_a6a5091a
PS3, Line 13: >
This needs to be >= to be effective (found by Coverity CID 1469611).
sigh, I forgot how to count. I'll push up a CL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61607
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8d7f0fe00794a715756f92e3fb32c6b512cb8aa
Gerrit-Change-Number: 61607
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 15 Feb 2022 17:14:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment