[coreboot-gerrit] [M] Change in coreboot[master]: cbmem_top_chipset: Change the return value to uintptr_t

[Angel Pons (Code Review)]

Attention is currently required from: Hung-Te Lin, Philipp Hug, Jakub Czapiga, Matt DeVillier, Julius Werner, Andrey Petrov, ron minnich, Elyes Haouas, Felix Held.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69078 )

Change subject: cbmem_top_chipset: Change the return value to uintptr_t
......................................................................

Patch Set 1: Code-Review+1

(3 comments)

File src/northbridge/intel/i440bx/memmap.c:

https://review.coreboot.org/c/coreboot/+/69078/comment/27b2a59a_304cc80a 
PS1, Line 48: int tseg_size = 128 * KiB * (1 << (tseg >> 1));
            : 		tom -= tseg_size;
> Shouldn't this be changed too? What's the purpose of integer type here? (And above too)

If anything, this belongs to a follow-up.

File src/northbridge/intel/x4x/memmap.c:

https://review.coreboot.org/c/coreboot/+/69078/comment/5f0452ea_065278ff 
PS1, Line 76: uintptr_t top_of_ram = ALIGN_DOWN(northbridge_get_tseg_base(), 4*MiB);
            : 	return top_of_ram;
> Can it fit in one line?

+1, there are other occurrences in other Intel platforms. Could be done in a follow-up.

File src/soc/nvidia/tegra124/cbmem.c:

https://review.coreboot.org/c/coreboot/+/69078/comment/deba1af8_8b1c603b 
PS1, Line 9: 	return ((sdram_max_addressable_mb() - FB_SIZE_MB) << 20UL);
nit: Outer set of parentheses is now unnecessary