[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/pch: Enable PCH Thermal Sensor for threshold configu...

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33129 )

Change subject: soc/intel/common/pch: Enable PCH Thermal Sensor for threshold configuration
......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33129/12/src/soc/intel/common/pch/t... 
File src/soc/intel/common/pch/thermal/thermal.c:

PS12:
> > But my point is that if you like to actually try to make further common code based on PCH alignment which is reasonable might exist inside common/pch.
>
> What kind of common code?

might be building soc/intel code further around PCH, like surrounding icl pch may be if we wish to do to accommodate future soc?
> Why does having it in block make it difficult?

common/block is dedicated to IPs and inside soc/intel directory we might have some common stage files as well like finalize.c, elog.c, smihandler.c, smmrelocation.c across all core family ? just a initial thought! similar effort might help us to land newer soc code.