Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36518 )
Change subject: trogdor: QCSDI loading depends on VB2_GBB_FLAG_RUNNING_FAFT setting flag
......................................................................
Patch Set 35:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36518/28/src/soc/qualcomm/common/qc...
File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/36518/28/src/soc/qualcomm/common/qc...
PS28, Line 130: struct vb2_context *ctx = vboot_get_context();
Where? There are no actual changes in the latest uploads.
Julius, we have tried your suggestion as is and it introduced issues that were picked up by BVT testing related to SDI and IDP. Until we resolve these issues we cannot adopt your suggestion. We will keep you updated on our progress.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36518
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63f35c94bc6c60934ace5fe0fd9176443059b354
Gerrit-Change-Number: 36518
Gerrit-PatchSet: 35
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: ashk@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Tue, 17 Mar 2020 15:51:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment