Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39998 )
Change subject: soc/amd/common/psp: Make common function to print status
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39998/1/src/soc/amd/common/block/ps...
File src/soc/amd/common/block/psp/psp.c:
https://review.coreboot.org/c/coreboot/+/39998/1/src/soc/amd/common/block/ps...
PS1, Line 240: printk(BIOS_DEBUG, "OK\n");
Use ternary operator?
this would increase the code density a bit, but i don't think that this would improve the readability, since those two cases have different code paths (constant vs. function call).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39998
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id8abe0d1d4ac87f6d4f625593f47bf484729906f
Gerrit-Change-Number: 39998
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Marshall Dawson
marshall.dawson@amd.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 01 Apr 2020 12:19:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment