Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32789 )
Change subject: soc/intel/icelake: Make use of gpio_pm_configure() ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/32789/7/src/soc/intel/icelake/chip.c File src/soc/intel/icelake/chip.c:
https://review.coreboot.org/#/c/32789/7/src/soc/intel/icelake/chip.c@121 PS7, Line 121: !value[i]
Its easy to miss the print in the huge set of logs printed during boot. How about this: […]
Done