Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41280 )
Change subject: security/tpm/tspi/crtm.c: Fix handling of white space delimited list
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Nice. Glad to have you in coreboot. If you could send a follow-up adding strtok() to our library, that’d be awesome.
https://review.coreboot.org/c/coreboot/+/41280/3/src/security/tpm/tspi/crtm....
File src/security/tpm/tspi/crtm.c:
https://review.coreboot.org/c/coreboot/+/41280/3/src/security/tpm/tspi/crtm....
PS3, Line 92: int
unsigned
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41280
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd285162ea6e562a5bb18325a1b767ac2e4276f3
Gerrit-Change-Number: 41280
Gerrit-PatchSet: 3
Gerrit-Owner: Harshit Sharma
harshitsharmajs@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Wed, 13 May 2020 12:35:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment