[coreboot-gerrit] Change in coreboot[master]: commonlib/bsd: Add new CBFS core implementation

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38421 )

Change subject: commonlib/bsd: Add new CBFS core implementation
......................................................................

Patch Set 13:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38421/11/src/commonlib/bsd/cbfs_pri... 
File src/commonlib/bsd/cbfs_private.c:

https://review.coreboot.org/c/coreboot/+/38421/11/src/commonlib/bsd/cbfs_pri... 
PS11, Line 75: 				  offset + sizeof(mdata.h), todo) != todo)
> Why not use an assert() here? I've decided to use assertions when I've already verified the conditio […]

Uhh... yeah, sure, why not. Unfortunately GCC is surprisingly bad at analyzing this and can't eliminate it (I filed https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97434 because I was curious). But I guess one more check shouldn't break the bank.

https://review.coreboot.org/c/coreboot/+/38421/11/src/commonlib/bsd/cbfs_pri... 
PS11, Line 117: 	const size_t todo = be32toh(src->h.offset) - already_read;
> cbfs_copy_fill_metadata() is only meant to be called from a |walker| callback to cbfs_walk(), where  […]

Added an assert() here as well.