2 comments:
File src/commonlib/bsd/cbfs_private.c:
Patch Set #11, Line 75: offset + sizeof(mdata.h), todo) != todo)
Why not use an assert() here? I've decided to use assertions when I've already verified the conditio […]
Uhh... yeah, sure, why not. Unfortunately GCC is surprisingly bad at analyzing this and can't eliminate it (I filed https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97434 because I was curious). But I guess one more check shouldn't break the bank.
Patch Set #11, Line 117: const size_t todo = be32toh(src->h.offset) - already_read;
cbfs_copy_fill_metadata() is only meant to be called from a |walker| callback to cbfs_walk(), where […]
Added an assert() here as well.
To view, visit change 38421. To unsubscribe, or for help writing mail filters, visit settings.