Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37832 )
Change subject: mb/google/hatch/var/jinlon: Update DPTF parameters
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37832/3/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/jinlon/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37832/3/src/mainboard/google/hatch/...
PS3, Line 2: register "tdp_pl2_override" = "51"
How about adding PL1 override here too? tdp_pl1_override = "15", as indicated in dptf.asl above?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37832
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I222bac5f04ba5cdde1788c6d4ca8af80d323ca98
Gerrit-Change-Number: 37832
Gerrit-PatchSet: 3
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 19 Dec 2019 17:38:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment