Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31917 )
Change subject: soc/intel/cnl: Generate DMAR ACPI table
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/#/c/31917/14/src/soc/intel/cannonlake/include/so...
File src/soc/intel/cannonlake/include/soc/systemagent.h:
https://review.coreboot.org/#/c/31917/14/src/soc/intel/cannonlake/include/so...
PS14, Line 42: #define VTBAR_ENABLED 0x01
: #define VTBAR_MASK 0x7ffffff000ull
These should be placed under GFXVTBAR as they are fields within that register.
Nvm. I see you are using it both for GFXVTBAR and VTVC0BAR.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31917
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e1ee5244c67affb13947436d81628c5dc665c9e
Gerrit-Change-Number: 31917
Gerrit-PatchSet: 14
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Assignee: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 10 Apr 2019 02:55:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment