[coreboot-gerrit] Change in coreboot[master]: soc/intel/block/acpi: add code for CPPC entries generation

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45535 )

Change subject: soc/intel/block/acpi: add code for CPPC entries generation
......................................................................

Patch Set 30:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45535/8/src/soc/intel/common/block/... 
File src/soc/intel/common/block/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/45535/8/src/soc/intel/common/block/... 
PS8, Line 372: /* version 2 */
> Is the comment really necessary? If you want to name arguments, you could pass […]

or use a #define

https://review.coreboot.org/c/coreboot/+/45535/30/src/soc/intel/common/block... 
File src/soc/intel/common/block/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/45535/30/src/soc/intel/common/block... 
PS30, Line 440: 
              : 			if (cpuid_eax(6) & CPUID_6_EAX_ISST)
nit: cpuid is a serializing instruction, and its values won't change, you could stuff this in a variable outside the loop