Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31236 )
Change subject: mb/google/hatch: Configure GPIOs again after FSP-S is done
......................................................................
Patch Set 1:
Patch Set 1:
Should we push this into cnl/cfl ? There are other boards affected.
Other boards currently have the same work around applied. One reason I did not put this in cnl/cfl common code is because it will have to make a copy of the gpio table or add another callback from SoC to mainboard. But I can look into that since I am not sure when exactly this will be fixed in FSP.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31236
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib197529a730f0142152c94ddf4a2b005bae123f5
Gerrit-Change-Number: 31236
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.corp-partner.google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Feb 2019 19:12:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment