Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32080 )
Change subject: : mainboard/asus/p8h61-m_pro : Add TPM module ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/#/c/32080/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32080/1//COMMIT_MSG@7 PS1, Line 7: Add TPM module Support TPM module
https://review.coreboot.org/#/c/32080/1//COMMIT_MSG@7 PS1, Line 7: : Please remove.
https://review.coreboot.org/#/c/32080/1//COMMIT_MSG@7 PS1, Line 7: mainboard/asus/p8h61-m_pro : Please remove the dot before the colon (:).
https://review.coreboot.org/#/c/32080/1//COMMIT_MSG@9 PS1, Line 9: modified mainboard/asus/p8h61-m_pro/Kconfig to include MAINBOARD_HAS_LPC_TPM : modified mainboard/asus/p8h61-m_pro/devicetree.cb to include drivers/pc80/tpm on device pnp 4e.0 Please remove.
Select support in Kconfig and configure the device in the devicetree.
https://review.coreboot.org/#/c/32080/1//COMMIT_MSG@11 PS1, Line 11: Tested with TPM 1.2 and 2.0. Do you have different modules? What module have you used for testing? Or is one included on the board?
https://review.coreboot.org/#/c/32080/1//COMMIT_MSG@11 PS1, Line 11: Seaboot SeaBIOS