Martin Roth (gaumless@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10894
-gerrit
commit ea7c3a4a17458d09ea37581aea6638bd60dac361 Author: Martin Roth gaumless@gmail.com Date: Sun Jul 12 20:15:20 2015 -0600
x86emu/debug.h: add back #ifdef CONFIG_DEFAULT_CONSOLE_LOGLEVEL
This reverts commit 3a391fd2 : x86emu/debug.h: remove #ifdef CONFIG_DEFAULT_CONSOLE_LOGLEVEL.
This #ifdef isn't here for the coreboot code itself, but is used in the util/vgabios code which builds in the emulation code.
I've added back the ifdef, and added a comment explaining why it's there. Long term, it might be better to rewrite the vgabios utility to use printk instead of printf.
The comment is on the same line as the ifdef so it can be seen in the output when grepping the code for '#ifdef CONFIG_'.
Change-Id: I148f2acb38b720bb4801c31ec950b248ba742f7e Signed-off-by: Martin Roth gaumless@gmail.com --- src/device/oprom/x86emu/debug.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/src/device/oprom/x86emu/debug.h b/src/device/oprom/x86emu/debug.h index 186c161..c7fbb1d 100644 --- a/src/device/oprom/x86emu/debug.h +++ b/src/device/oprom/x86emu/debug.h @@ -42,8 +42,10 @@
/*---------------------- Macros and type definitions ----------------------*/
+#ifdef CONFIG_DEFAULT_CONSOLE_LOGLEVEL /* #ifdef for compiling util/vgabios */ /* printf is not available in coreboot... use printk */ #define printf(x...) printk(BIOS_DEBUG, x) +#endif
/* checks to be enabled for "runtime" */