Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45856 )
Change subject: soc/intel/jasperlake: Allow mainboard to override chip configuration
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45856/1/src/soc/intel/jasperlake/fs...
File src/soc/intel/jasperlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/45856/1/src/soc/intel/jasperlake/fs...
PS1, Line 94: override
Shouldn't this be run at the end so that it can actually override something?
This way it's more like the board can provide defaults and the code below
would have the last word.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45856
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40fa655b0324dc444182b988f0089587e3877a47
Gerrit-Change-Number: 45856
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 01 Oct 2020 19:29:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment