Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34173 )
Change subject: southbridge/intel/common/spi.c: Increase SPI-flash erase timeout ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34173/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34173/4//COMMIT_MSG@17 PS4, Line 17: value is necessary. Please adhere to the 72-char line length limit in commit messages.
https://review.coreboot.org/c/coreboot/+/34173/4/src/southbridge/intel/commo... File src/southbridge/intel/common/spi.c:
https://review.coreboot.org/c/coreboot/+/34173/4/src/southbridge/intel/commo... PS4, Line 34: #include "drivers/spi/spi_flash_internal.h" Please use <>, as it's not relative to the location of this file.
https://review.coreboot.org/c/coreboot/+/34173/4/src/southbridge/intel/commo... PS4, Line 731: unsigned int timeout = 1000 * SPI_FLASH_PROG_TIMEOUT; Why not SPI_FLASH_SECTOR_ERASE_TIMEOUT? That seems to fit much better by name.