Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39765 )
Change subject: mb/up/squared: rewrite GPIO config using intelp2m
......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39765/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39765/3//COMMIT_MSG@17
PS3, Line 17: [WIP] Please review and test coreboot image with this patch
I have another idea. […]
That would need to be done using three patches:
1. Convert to _PAD_CFG_STRUCT(), timelessly
2. Drop unneeded values, changing the binary
3. Convert to PAD_CFG_*() macros, timelessly
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39765
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I266ec6fa10a9691a7b7d3cd6f2792624e8bd53d5
Gerrit-Change-Number: 39765
Gerrit-PatchSet: 15
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 10 Jun 2020 07:55:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment