Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44812 )
Change subject: soc/intel/elkhartlake/acpi: Copy acpi directory from jasperlake ......................................................................
Patch Set 8: Code-Review+1
(5 comments)
There are a few of PCI device number mismatches in my point of view (not sure if all questions are valid). Do you want it to address in a follow-up commit or clarify them right in this commit?
https://review.coreboot.org/c/coreboot/+/44812/8/src/soc/intel/elkhartlake/a... File src/soc/intel/elkhartlake/acpi/pch_glan.asl:
https://review.coreboot.org/c/coreboot/+/44812/8/src/soc/intel/elkhartlake/a... PS8, Line 3: /* Intel Gigabit Ethernet Controller 0:1f.6 */ Is this still true for EHL?
https://review.coreboot.org/c/coreboot/+/44812/8/src/soc/intel/elkhartlake/a... File src/soc/intel/elkhartlake/acpi/pcie.asl:
https://review.coreboot.org/c/coreboot/+/44812/8/src/soc/intel/elkhartlake/a... PS8, Line 220: Name (_ADR, 0x001C0007) Is that still true for EHL?
https://review.coreboot.org/c/coreboot/+/44812/8/src/soc/intel/elkhartlake/a... PS8, Line 252: Device (RP10) Not sure weather EHL have all these ports around. Isn't 0x1D devie the PSE frontend?
https://review.coreboot.org/c/coreboot/+/44812/8/src/soc/intel/elkhartlake/a... File src/soc/intel/elkhartlake/acpi/scs.asl:
https://review.coreboot.org/c/coreboot/+/44812/8/src/soc/intel/elkhartlake/a... PS8, Line 71: Name (_ADR, 0x00140005) Is this valid for EHL?
https://review.coreboot.org/c/coreboot/+/44812/8/src/soc/intel/elkhartlake/a... File src/soc/intel/elkhartlake/acpi/serialio.asl:
https://review.coreboot.org/c/coreboot/+/44812/8/src/soc/intel/elkhartlake/a... PS8, Line 55: 0x00120006 Shouldn't taht be 0x00120000 for EHL?