Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38716 )
Change subject: mb/google/octopus: Override VBT selection for Bloog
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38716/6/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/bloog/variant.c:
https://review.coreboot.org/c/coreboot/+/38716/6/src/mainboard/google/octopu...
PS6, Line 69:
Nit: Align this line with the sku_id in the previous line. That way return "vbt.bin"; statement has a different alignment and make it more readable.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38716
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I61f12d4ddea17a05255751fde2a5ce822dd2e782
Gerrit-Change-Number: 38716
Gerrit-PatchSet: 6
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 06 Feb 2020 05:52:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment