Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Paul Menzel, Julius Werner, Zheng Bao, Elyes Haouas, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Paul Menzel, Zheng Bao, Elyes Haouas, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62750
to look at the new patch set (#8).
Change subject: $top/Makefile.inc: "-include" the folder common before other subdirs ......................................................................
$top/Makefile.inc: "-include" the folder common before other subdirs
Put src/soc/*/common before src/soc/*/*, can make the variables in common Makefile get the expected value before they are used in other subdirs.
The result subdirs-y gets duplicated "common", which is eliminated later by 1. "-include" directive when creating the list of Makefile.inc. 2. sort function when create xxx-src variable.
Then we can put some common variables from all the subdir Makefile.inc to the common Makefile.inc to reduce code redundancy.
Change-Id: I99597af22cac6d12aaef348789664cd7db02ba06 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M Makefile.inc 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/62750/8