[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Enable support for WWAN

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30678 )

Change subject: mb/google/hatch: Enable support for WWAN
......................................................................

Patch Set 7:

(3 comments)

https://review.coreboot.org/#/c/30678/7/src/mainboard/google/hatch/variants/... 
File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/30678/7/src/mainboard/google/hatch/variants/... 
PS7, Line 55: 0
Is this the right value for this GPIO?

https://review.coreboot.org/#/c/30678/7/src/mainboard/google/hatch/variants/... 
PS7, Line 72: /* WWAN_CONFIG_0 */
            : 	PAD_CFG_GPI(GPP_D5, NONE, DEEP),
            : 	/* WWAN_CONFIG_1 */
            : 	PAD_CFG_GPI(GPP_D6, NONE, DEEP),
            : 	/* WWAN_CONFIG_2 */
            : 	PAD_CFG_GPI(GPP_D7, NONE, DEEP),
            : 	/* WWAN_CONFIG_3 */
            : 	PAD_CFG_GPI(GPP_D8, NONE, DEEP),
Since we are not yet sure how or if this will be used, let's just configure it as NC.

https://review.coreboot.org/#/c/30678/7/src/mainboard/google/hatch/variants/... 
PS7, Line 113: 0
1?