Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46962 )
Change subject: mb/google/hatch/jinlon: Describe the privacy_gpio
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/46962/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/jinlon/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46962/1/src/mainboard/google/hatch/...
PS1, Line 86: chip drivers/usb/acpi
I tried removing the first […]
Ah, it probably placed the privacy_gpio on the `_SB.PCI0.XHCI.RHUB` scope instead of the USB port's scope.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46962
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa628dda03f3f65976850aeabaf516f528a921b7
Gerrit-Change-Number: 46962
Gerrit-PatchSet: 1
Gerrit-Owner: Ricardo Ribalda
ribalda@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 02 Nov 2020 21:00:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Ricardo Ribalda
ribalda@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment