Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42450 )
Change subject: nb/intel/sandybridge/gma.c: Add Kconfig options for RC6 and RC6p ......................................................................
Patch Set 3:
(6 comments)
https://review.coreboot.org/c/coreboot/+/42450/2/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/Kconfig:
https://review.coreboot.org/c/coreboot/+/42450/2/src/northbridge/intel/sandy... PS2, Line 132: ENABLE_RC6
Make it clear that it's for the iGPU? […]
Done
https://review.coreboot.org/c/coreboot/+/42450/2/src/northbridge/intel/sandy... PS2, Line 138: ENABLE_RC6P
GMA_ENABLE_RC6P
Done
https://review.coreboot.org/c/coreboot/+/42450/2/src/northbridge/intel/sandy... PS2, Line 144: This should only be selected on Ivy Bridge.
We can check that it's Ivy Bridge at runtime, see comments on the code. Maybe say: […]
Done
https://review.coreboot.org/c/coreboot/+/42450/2/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/gma.c:
https://review.coreboot.org/c/coreboot/+/42450/2/src/northbridge/intel/sandy... PS2, Line 455: #if CONFIG(ENABLE_RC6)
Why not make this code flexible enough so that RC6p can be enabled correctly without RC6? It's just […]
Okay, done.
https://review.coreboot.org/c/coreboot/+/42450/2/src/northbridge/intel/sandy... PS2, Line 461: gtt_write(0xa090, reg32);
Where did the comment go?
It was lost :)
https://review.coreboot.org/c/coreboot/+/42450/2/src/northbridge/intel/sandy... PS2, Line 520: #if CONFIG(ENABLE_RC6) || CONFIG(ENABLE_RC6P)
How about: […]
Done