Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44471 )
Change subject: soc/intel/common/gpio_defs: Remove incorrent GPO macro
......................................................................
Patch Set 2: Code-Review-1
Sorry to delaying this, once again :S I found something in the linux pinctrl driver (linux/drivers/pinctrl/intel/pinctrl-intel.c). Look for intel_config_get/set(), intel_pad_usable() and intel_pad_owned_by_host(). pinctrl only allows to control pads that have ownership set to driver. That confirms my initial idea that driver mode is to control which pads are allowed to be altered by the OS (driver mode) or not (ACPI mode). Further, it applies to GPI, as well as GPO.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44471
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74c318897647836f4604a937543254f44b470433
Gerrit-Change-Number: 44471
Gerrit-PatchSet: 2
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 09 Oct 2020 16:31:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment