Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47039 )
Change subject: mb/google/volteer/var/elemi: Update gpio and devicetree ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47039/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/elemi/gpio.c:
https://review.coreboot.org/c/coreboot/+/47039/3/src/mainboard/google/voltee... PS3, Line 93: 1 0, the power resource in ACPI will handle proper power sequencing
https://review.coreboot.org/c/coreboot/+/47039/3/src/mainboard/google/voltee... PS3, Line 189: /* B2 : VRALERT# ==> EN_PP3300_SSD */ : PAD_CFG_GPO(GPP_B2, 1, DEEP), : /* B4 : CPU_GP3==> EN_PP3300_EMMC */ : PAD_CFG_GPO(GPP_B4, 1, DEEP), Do these need to be set in the early GPIO table?