Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43502 )
Change subject: mb/ocp/tiogapass: Use macro to configure IIO
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/43502/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43502/3//COMMIT_MSG@11
PS3, Line 11: more understandable
I'd say "easier to read". I don't think this change helps one understand what the magic fields are about, but at least it's tidier 😊
https://review.coreboot.org/c/coreboot/+/43502/3//COMMIT_MSG@13
PS3, Line 13: The test with BUILD_TIMELESS = 1 is successfully.
: The images before and after the patch are the same.
Yes, but which board did you test this with? I generally use something along the lines of:
Tested with BUILD_TIMELESS=1, <board name> remains identical.
Fits in one line and provides the necessary info 😉
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43502
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2911992435a6c93624525426d56212f821abb866
Gerrit-Change-Number: 43502
Gerrit-PatchSet: 3
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 20 Jul 2020 12:56:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment