Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34563 )
Change subject: soc/intel/cannonlake: Enable ACPI timer emulation if PM timer is disabled
......................................................................
Patch Set 3:
Patch Set 3:
Created a revert of this change as If0d7fa6f9766c7c4e2fa9e846c179adc6a4e1681
I guess we should first ask why this check was added?
Aamir, Subrata, Furquan, do you know the reason for this
change? The BIOS spec seems to suggest to always enable
it. Are there any downsides?
Please always mention the reason for a change in the
commit message.
Posted response on https://review.coreboot.org/c/coreboot/+/45000.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34563
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21c0b89218d0df9336e0b0e15f1b575b8508fb96
Gerrit-Change-Number: 34563
Gerrit-PatchSet: 3
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 14 Oct 2020 04:40:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment