Attention is currently required from: Shelley Chen, Ravi Kumar Bokka, Hung-Te Lin, Nico Huber, Tim Wawrzynczak, Paul Menzel, Rex-BC Chen, Julius Werner, Arthur Heymans, Yu-Ping Wu, Jianjun Wang.
Veerabhadrarao Badiganti has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63251 )
Change subject: coreboot_tables: Add PCIe info to coreboot table
......................................................................
Patch Set 20:
(1 comment)
Patchset:
PS9:
Hi Yu-ping. […]
Hi,
If we have the ctrl_base, the rest three parameters (atu_base, mmio_base,mmio_size) remain constant on Qualcomm SoC. I checked different SoCs, on all of them they remain same/constant.
On 1MB size of mmio_size => on a single bus we can have max 32 devices and each device we can have max 8 functions. And each of this function can have 4KB config space. To accommodate config space for max possible devices we are assigning 1MB (4KB * 32 * 8).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63251
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6cdce21efc66aa441ec077e6fc1d5d1c6a9aafb0
Gerrit-Change-Number: 63251
Gerrit-PatchSet: 20
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Ravi Kumar Bokka
rbokka@codeaurora.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Prasad Malisetty
pmaliset@qualcomm.corp-partner.google.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-CC: Veerabhadrarao Badiganti
vbadigan@qualcomm.corp-partner.google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi Kumar Bokka
rbokka@codeaurora.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Comment-Date: Fri, 06 May 2022 12:25:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-MessageType: comment