5 Apr
2022
5 Apr
'22
7:54 p.m.
Attention is currently required from: Arthur Heymans, Martin Roth, Julius Werner, Yu-Ping Wu. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59132 )
Change subject: Makefile.inc: Generate master header and pointer as C structs ......................................................................
Patch Set 8:
(1 comment)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/59132/comment/4113bf98_3db57cc8 PS4, Line 1150: 32
Nit: Maybe put some of these numbers into variables? Some comments as to what's going on here mig […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/59132
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ba01be7da1f09a8cac287751497c18cda97d293
Gerrit-Change-Number: 59132
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Tue, 05 Apr 2022 19:54:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth martinroth@google.com
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment