12 Sep
2020
12 Sep
'20
2:10 a.m.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44837 )
Change subject: mb/getac/p470: Use PNP_IDX_EN instead of magic number ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44837/1/src/mainboard/getac/p470/ea... File src/mainboard/getac/p470/early_init.c:
https://review.coreboot.org/c/coreboot/+/44837/1/src/mainboard/getac/p470/ea... PS1, Line 79: pnp_write_config(dev, PNP_IDX_EN, (0x600 >> 4)); // Runtime Register Block Base
I'm unsure if this one is semantically correct, since the SMSC SIO chips are the ones that don't fol […]
You are right Thanks
--
To view, visit https://review.coreboot.org/c/coreboot/+/44837
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie75e29ed307647f20a5b74deb6d998278fb99b7d
Gerrit-Change-Number: 44837
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 12 Sep 2020 02:10:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment