Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45828 )
Change subject: mb/intel/tglrvp: Enable Pcie WWAN m.2 ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45828/3/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c:
https://review.coreboot.org/c/coreboot/+/45828/3/src/mainboard/intel/tglrvp/... PS3, Line 99: PLTRST
Can we use DEEP? We used DEEP for other configuration.
Done
https://review.coreboot.org/c/coreboot/+/45828/3/src/mainboard/intel/tglrvp/... PS3, Line 102: PAD_CFG_GPO(GPP_C11, 1, PLTRST), /* FULL_CARD_POWER_OFF_N */ : PAD_CFG_GPO(GPP_C10, 1, PLTRST), /* WWAN_RST_N */ : PAD_CFG_GPO(GPP_B17, 1, PLTRST), /* WWAN_PERST_N */ : PAD_CFG_GPO(GPP_D15, 1, PLTRST), /* WWAN_DISABLE_N */
thanks we will check
Done
https://review.coreboot.org/c/coreboot/+/45828/3/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/variants/tglrvp_up4/gpio.c:
https://review.coreboot.org/c/coreboot/+/45828/3/src/mainboard/intel/tglrvp/... PS3, Line 95: PAD_CFG_GPO(GPP_D11, 1, PLTRST), /* WWAN_PWREN */
Can we use DEEP? We used DEEP for other configuration.
Done
https://review.coreboot.org/c/coreboot/+/45828/3/src/mainboard/intel/tglrvp/... PS3, Line 98: PAD_CFG_GPO(GPP_C11, 1, PLTRST), /* FULL_CARD_POWER_OFF_N */ : PAD_CFG_GPO(GPP_C10, 1, PLTRST), /* WWAN_RST_N */ : PAD_CFG_GPO(GPP_B17, 1, PLTRST), /* WWAN_PERST_N */ : PAD_CFG_GPO(GPP_D15, 1, PLTRST), /* WWAN_DISABLE_N */
Can we use DEEP? We used DEEP for other configuration.
Done