Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: mb/asus: Add Asus A88XM-E FM2+ with documentation
......................................................................
Patch Set 77:
(3 comments)
https://review.coreboot.org/c/coreboot/+/30987/66/src/mainboard/asus/a88xm-e...
File src/mainboard/asus/a88xm-e/bootblock.c:
https://review.coreboot.org/c/coreboot/+/30987/66/src/mainboard/asus/a88xm-e...
PS66, Line 14: 0xffc7ffff
Masking of certain bits is usually done with an and-not operation. […]
Done
https://review.coreboot.org/c/coreboot/+/30987/66/src/mainboard/asus/a88xm-e...
PS66, Line 15: 0x00100000
Would be clearer to use: […]
Done
https://review.coreboot.org/c/coreboot/+/30987/66/src/mainboard/asus/a88xm-e...
PS66, Line 19: (~0x80u)
~(1 << 7)
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30987
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60fa0636ba41f5f1a6a3faa2764bf2f0a968cf90
Gerrit-Change-Number: 30987
Gerrit-PatchSet: 77
Gerrit-Owner: Balázs Vinarz
vinibali1@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Balázs Vinarz
vinibali1@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 21 May 2020 15:08:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment