Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47051 )
Change subject: mb/purism/librem_cnl: Adjust in preparation for new variants ......................................................................
Patch Set 1:
huh? ofc you shouldn't do that. see Angel's example which boils down to a few lines Kconfig in your case
adding 2 new baseboards only to select the SoC, just to keep everything in Kconfig seems like a tortured exercise just to adhere to an arbitrary guideline, but I will relent and adjust
it's a ~10 LOC change; I don't see the "tortured exercise" ;-)
Then look closer.
The original patch was correct by current coreboot standards. I'm not sure if a single of the proposed alternatives is. You seem to have the time to play around until Kconfig and your pickyness are happy. But that's not true for every author. I didn't read all comments but I doubt there's something like "if you have the time" along the lines.
So, the original patch was ok. What if you are happy with the next version but another reviewer isn't? With all the noise in the com- ments, there's no guarantee that a different version will get in easier.