Attention is currently required from: Bartłomiej Grzesik, Julius Werner, Konrad Adamczyk, Yu-Ping Wu.
Jakub "Kuba" Czapiga has posted comments on this change by Bartłomiej Grzesik. ( https://review.coreboot.org/c/coreboot/+/87107?usp=email )
Change subject: Add allocation of a buffer for pvmfw within cbmem
......................................................................
Patch Set 2:
(3 comments)
File src/vendorcode/google/Kconfig:
https://review.coreboot.org/c/coreboot/+/87107/comment/15ff6da2_ff3aedde?usp... :
PS2, Line 32:
Unnecessary empty line
File src/vendorcode/google/pvmfw_cbmem.c:
https://review.coreboot.org/c/coreboot/+/87107/comment/7d5fd4cc_09ba64e6?usp... :
PS2, Line 7: unused
Please add `(void)(unused);` to make sure the warnings are suppressed.
https://review.coreboot.org/c/coreboot/+/87107/comment/0c9727ff_3dcd231c?usp... :
PS2, Line 14: return;
Unnecessary return statement. Without it the if-statement can be brace-less.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87107?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I48efc033ac0f5fbfcf3a52fabf40be016cd4c6f7
Gerrit-Change-Number: 87107
Gerrit-PatchSet: 2
Gerrit-Owner: Bartłomiej Grzesik
bgrzesik@google.com
Gerrit-Reviewer: Jakub "Kuba" Czapiga
czapiga@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Konrad Adamczyk
konrada@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Konrad Adamczyk
konrada@google.com
Gerrit-Attention: Bartłomiej Grzesik
bgrzesik@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 03 Apr 2025 10:58:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No