Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36065 )
Change subject: mainboard/google: Initial Puff board support ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36065/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36065/2//COMMIT_MSG@7 PS2, Line 7: mainboard/google: Initial Puff board support Please add a verb to make it a statement, and shorten the prefix:
mb/google: Add initial Puff board support
https://review.coreboot.org/c/coreboot/+/36065/2//COMMIT_MSG@9 PS2, Line 9: Workout Work out
https://review.coreboot.org/c/coreboot/+/36065/2/src/mainboard/google/puff/r... File src/mainboard/google/puff/ramstage.c:
https://review.coreboot.org/c/coreboot/+/36065/2/src/mainboard/google/puff/r... PS2, Line 38: override_gpios); Does this fit on one line with the new line length limit?