Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42953 )
Change subject: mb/intel/tglrvp: Add PMC.MUX.CONx devices to devicetree for tglrvp_up3
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42953/2/src/mainboard/intel/tglrvp/...
File src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/42953/2/src/mainboard/intel/tglrvp/...
PS2, Line 265: SBU & HSL follow CC
i'm not sure how the tglrvp is configured,
but shouldn't this be the same as port 1?
i.e. the BB "fixes" the SBU orientation?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42953
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7210e00cebe16a5fb8417ac23abad98e574e0982
Gerrit-Change-Number: 42953
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 06 Jul 2020 21:39:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment