31 Aug
2020
31 Aug
'20
9:08 p.m.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44862 )
Change subject: mb/google/zork: update DRAM table for berknip ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44862/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/44862/4/src/mainboard/google/zork/v... PS4, Line 8: 9
Why is this part being assigned ID 9? We should let the tool select the ID. […]
See "Tool 2 - gen_part_id.go" section of the spd_tools ddr4 README.md: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/th...
--
To view, visit https://review.coreboot.org/c/coreboot/+/44862
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia21a561e9b89feeccb6509d9280eaf52cfc2f5a3
Gerrit-Change-Number: 44862
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 31 Aug 2020 19:08:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment